This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
feat: clean up partition limiter state on schedule #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvello
approved these changes
Dec 13, 2023
| interval.tick().await; | ||
|
|
||
| self.limiter.retain_recent(); | ||
| self.limiter.shrink_to_fit(); |
There was a problem hiding this comment.
nit: because we know that we'll see new distinct_ids soon (as sessions churn from visitor to visitor), I don't think the cost of shrink is worth it now, I'd just run retain every 5 minutes, which should in theory keep the active key count bounded. Alternatively, we could shrink before we retain, to only re-allocate the map if it didn't grow back after the last retain.
But it's safe to merge as is and tune later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May not be the cause of our issues, however is good to have regardless
Will want to test in dev to ensure performance is not impacted. Note that if it is impacted, we may want to do some sort of atomic swap. I don't think it will be an issue for where we are now though