Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

fix MessageSizeTooLarge handling #66

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Dec 7, 2023

We were matching on the wrong Kafka error code: InvalidMessageSize instead of MessageSizeTooLarge, leading to 503s here instead of 400s.

@xvello xvello requested a review from ellie December 7, 2023 15:05
Copy link
Contributor

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're annoyingly similarly named

@xvello xvello merged commit fa43c0a into main Dec 7, 2023
4 checks passed
@xvello xvello deleted the xvello/MessageSizeTooLarge branch December 7, 2023 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants