Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made a grayscale version of vscode.lua #27

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheAio
Copy link
Contributor

@TheAio TheAio commented Sep 1, 2023

Made a grayscale version of vscode.lua,
to begin resolving issue #13 however i want to resolve PR #22 first because i would like to
implement a check via term.isColor() in the installer to decide if the grayscale version or color version should be installed.

@Possseidon
Copy link
Owner

i would like to implement a check via term.isColor() in the installer to decide if the grayscale version or color version should be installed

Neat idea actually!

Although just using the colored config on basic computers works pretty good at the moment too. Both advanced and basic computers nowadays support 16 colors using a configurable palette. Basic computers just only allow grayscale tones in that palette, but the default palette already looks pretty good:

image

The main issue currently is text-selection, which should have some custom rules here so that we can ensure a high enough contrast. Especially strings are currently completely invisible when selected on a basic computer:

image

I think it makes more sense to add some custom logic to the text-selection rendering to enable high enough contrast instead of just relying on theming. Otherwise you'd have to limit your grayscale choices quite a bit just so selections remain readable.


And this whole theming discussion also leads into another topic of allowing custom palettes which could allow for better looking themes in general. You're still limited by 16 colors in total, but picking which 16 colors to use can make a pretty big difference, especially for picking colors with good contrast and such.

Once I get around to actually properly implementing themes (as in, the whole application and not just text highlighting) I should definitely make it possible to customize this palette. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants