-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Port: The Aspect #1268
base: main
Are you sure you want to change the base?
New Port: The Aspect #1268
Conversation
Trying to port The Aspect 2-4
did i do it? |
So I messed it all up?
…On Tue, Feb 4, 2025, 4:32 PM tabreturn ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
On ports/theaspect/README.md
<#1268 (comment)>
:
1. ##Controls --> ## Controls
2. the controls info is not formatted in a markdown table
------------------------------
On ports/theaspect/gameinfo.xml
<#1268 (comment)>
:
I think refers to game type, not theme. Like, platformer, etc.
------------------------------
On ports/theaspect/port.json
<#1268 (comment)>
:
"items": [
"The Aspect",
...
above must include .sh
"items": [
"The Aspect.sh",
...
------------------------------
On ports/theaspect/screenshot.png
<#1268 (comment)>
:
Screenshot must be 640 x 480 (and please don't just squish it -- it should
be letterboxed, as it appears on a 640 x 480 screen)
------------------------------
On ports/theaspect/port.json
<#1268 (comment)>
:
Surely the "genres" should be "platformer"?
—
Reply to this email directly, view it on GitHub
<#1268 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BO4CZU3QVLEKGCFCFBYSCTL2OFEXLAVCNFSM6AAAAABWPPDJYSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOJUGI4DINJRHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
try#3. ## COntrols (spaced) and cover is 640x480
fixed screenshot.png name and 640x480 and "platformer".
Co-authored-by: Andrew <[email protected]>
Got rid of cover.png leaving only thr screenshot.png
Fixed name and added tabretun as a porter
Added url
Changed zefrost to backterria. Totally my mistake.
Approved.
…On Wed, Feb 5, 2025, 2:56 PM Cyril Delétré ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In ports/theaspect/README.md
<#1268 (comment)>
:
> +Thanks to Backterria for creating this fun little short game!
+https://backterria.itch.io/the-aspect
⬇️ Suggested change
-Thanks to Backterria for creating this fun little short game!
-https://backterria.itch.io/the-aspect
+Thanks to [Backterria](https://backterria.itch.io/) for creating this fun little short game!
------------------------------
In ports/theaspect/The Aspect.sh
<#1268 (comment)>
:
> +export PORT_32BIT="Y"
+[ -f "${controlfolder}/mod_${CFW_NAME}.txt" ] && source "${controlfolder}/mod_${CFW_NAME}.txt"
+get_controls
+
+GAMEDIR="/$directory/ports/theaspect"
+
+export LD_LIBRARY_PATH="/usr/lib32:$GAMEDIR/libs:$LD_LIBRARY_PATH"
+export GMLOADER_DEPTH_DISABLE=1
+export GMLOADER_SAVEDIR="$GAMEDIR/gamedata/"
+export GMLOADER_PLATFORM="os_linux"
+
+# We log the execution of the script into log.txt
+> "$GAMEDIR/log.txt" && exec > >(tee "$GAMEDIR/log.txt") 2>&1
+
+cd $GAMEDIR
+
Just in case someone install the port by unzipping from Windows
⬇️ Suggested change
-
+
+$ESUDO chmod u+x "$GAMEDIR/gmloader"
+$ESUDO chmod u+x "$GAMEDIR/7zzs"
—
Reply to this email directly, view it on GitHub
<#1268 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BO4CZU2JFLARAJH4JVERB5L2OKCILAVCNFSM6AAAAABWPPDJYSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOJXGA2DSOBSGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Co-authored-by: Cyril Delétré <[email protected]>
You forgot to update the launch script and/or commit your changes I think :) |
Fixed .sh adding ESUDO.
ports/theaspect/The Aspect.sh
Outdated
|
||
$GPTOKEYB "gmloader" -c ./theaspect.gptk & | ||
|
||
$ESUDO chmod +x "$GAMEDIR/gmloader" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ESUDO chmod +x "$GAMEDIR/gmloader" |
This is now a duplicate and can be removed.
Removed line 57 duplicate ESUDO chmod/gmloader
ports/theaspect/README.md
Outdated
|-- |-- | | ||
|Dpad |Movement| | ||
|A button |Jump | | ||
|B button |Ineract | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ineract --> Interact
Edited interact rypo
Trying to port The Aspect 2-4
New Port for (The Aspect)
Game Information
Submission Requirements
CFW Tests
Ensure your game has been tested on all major CFWs:
Resolution Tests
Test all major resolutions:
File Structure
Additional Resources
For an in-depth guide on creating a pull request, refer to: PortMaster Game Packaging Guide