Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fail condition in link checker #917

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mre
Copy link

@mre mre commented Feb 4, 2025

Fix fail condition for lychee link checker:
The link checker is currently misconfigured and fails with an error message:

Run lycheeverse/[email protected]
Run curl -sLO "https://github.com/lycheeverse/lychee/releases/download/v0.13.0/lychee-v0.13.0-x86_64-unknown-linux-gnu.tar.gz"
lychee
Run /home/runner/work/_actions/lycheeverse/lychee-action/v1.8.0/entrypoint.sh
error: unexpected argument '--fail' found

  note: to pass '--fail' as a value, use '-- --fail'

Usage: lychee --format <FORMAT> --output <OUTPUT> --no-progress <--verbose...|--quiet...> <inputs>...

For more information, try '--help'.

The reason is that the syntax is incorrect. --fail is not a flag of lychee, but a parameter of lychee-action.

Description:

  • Fixes the syntax and passes fail: true to the action.
  • Removes the non-existent --fail flag

Motivation:
The misconfigured action silently ignored link checking issues.
As a consequence, some links are currently broken, but that's a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant