improvement: inject plugins through HooksManager constructor #795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inject plugins through HooksManager constructor instead of directly define in it.
Motivation:
In our sveltekit project, we're using this repo as a submodule and import some part to create Hono instance and attach it to our backend. When we deploy it to Cloudflare Pages, it failed because the plugins in HooksManager depend on Node API (#601). So we copied
middlewares/hooks/index.ts
and commented out the plugins part, and use the hooks middleware in our Hono instance.if plugins are injectable through HooksManager constructor, we only need to copy the hooks middleware part.
Related Issues: