Add WebAudio backend #902
Closed
Add WebAudio backend #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The origina commit was modified to apply better to modern versions of PortAudio. (cherry picked from commit 69c5800) Co-authored-by: Adam Hilss
These are based off the instructions from portaudio-wasm Co-authored-by: Adam Hilss
|
CC @ahilss. |
|
Ah. I did not see that PR. I'll close this one in favor of #887. |
|
Please feel free to improve the other PR! Haven't had a lot of time to work on that lately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request integrates changes from https://github.com/ahilss/portaudio-wasm, which is used in Wavacity, a version of Audacity ported to WebAssembly. I haven't tested this backend to see if it either compiles or works yet.
The motivation behind this pull request is a request by one of Tenacity's former maintainers to integrate patches from Wavacity and making Tenacity capable of targeting WebAssembly. That issue can be found here. I was pretty impressed by Wavacity myself, but since it requires a forked version of PortAudio and wxWidgets, I decided to integrate patches from these forks into their upstream counterparts. I figured I'd start with PortAudio first because it looks like it's the easiest because of the minimal changes involved.
This pull request is marked as a draft at the moment because, as I've stated earlier, I haven't tested anything yet. Notably, I've tried to rework CMake support so I think it fits in with the latest versions of PortAudio. Once I get to testing, I will make any appropriate changes. I will also incorporate any suggestions too. Furthermore, any PortAudio maintainer is allowed to make changes to this PR in case I am busy with something else.