This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
Add initial custom-element standard snippet #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rictic
reviewed
Dec 8, 2017
| @@ -0,0 +1,19 @@ | |||
| import {CompletionItemKind, InsertTextFormat} from 'vscode-languageserver'; | |||
src/standard-snippets.ts
Outdated
| @@ -0,0 +1,19 @@ | |||
| import {CompletionItemKind, InsertTextFormat} from 'vscode-languageserver'; | |||
|
|
|||
| export default [ | |||
There was a problem hiding this comment.
Recommend giving this a name, as these are specifically snippets for when the user is in a JS file.
src/test/auto-completer_test.ts
Outdated
| @@ -437,7 +438,7 @@ suite('AutoCompleter', () => { | |||
| await client.openFile(indexFile, '<script>\n\n</script>\n' + indexContents); | |||
| const completions = | |||
| await client.getCompletions(indexFile, {line: 1, column: 0}); | |||
| assert.deepEqual(completions, {isIncomplete: true, items: []}); | |||
| assert.deepEqual(completions, {isIncomplete: false, items: standardSnippets}); | |||
| @@ -114,6 +115,7 @@ export default class AutoCompleter extends Handler { | |||
| if (location.kind === 'attribute') { | |||
| return this.getAttributeCompletions(document, location); | |||
| } | |||
| return this.getStandardSnippetCompletions(); | |||
There was a problem hiding this comment.
Hm, should explicitly check for the location being inside of a script section, as we might add other location kinds.
For bonus points it would be cool to do to JS what we did for CSS, and have an entire class of result for locResult.language === js but that might be more than you're interested in doing right now.
There was a problem hiding this comment.
I left a TODO, as I tried to make that work, but it required new AST traversal methods in ast-from-source-position, which seemed too much for this PR. Should be fixed someday though 😄
rictic
approved these changes
Dec 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple standard snippet for a custom element definition. I didn't want to publish Polymer-specific definitions yet, as HTML imports are gone and test suites are probably going to change as well. Once the dust is settled, we can discuss extra snippets.
Fixes Polymer/atom-plugin#11
Supersedes #36
This change is