-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adapt allay update #484
base: ver/6.6.0
Are you sure you want to change the base?
Conversation
* feat: update mapping files to latest
buildSrc/src/main/kotlin/Versions.kt
Outdated
@@ -13,7 +13,7 @@ object Versions { | |||
const val caffeine = "3.1.8" | |||
|
|||
const val slf4j = "2.0.16" | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reformat code to remove this
return JeBlockState.create((String) data.get("Name"), | ||
new TreeMap<>((Map<String, String>) data.getOrDefault("Properties", Map.of()))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this two lines instead of one?
and if it's too long to fit on a single line, it should really be
return JeBlockState.create(
(String) data.get("Name"),
new TreeMap<>((Map<String, String>) data.getOrDefault("Properties", Map.of()))
);
(or whatever the code formatted with the editorconfig file applied is)
platforms/allay/src/main/java/com/dfsek/terra/allay/Mapping.java
Outdated
Show resolved
Hide resolved
platforms/allay/src/main/java/com/dfsek/terra/allay/Mapping.java
Outdated
Show resolved
Hide resolved
platforms/allay/src/main/java/com/dfsek/terra/allay/Mapping.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/kotlin/Versions.kt
Outdated
object CLI { | ||
const val logback = "1.5.8" | ||
const val picocli = "4.7.6" | ||
} | ||
|
||
object Allay { | ||
const val api = "0114e0b290" | ||
const val api = "master-SNAPSHOT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use a specific version rather than master-SNAPSHOT
, to ensure reproducibility (ie. if someone 5 years from now tries to build it, it should still build just fine & should produce the same output)
ah, you're not the person who originally added the allay platform, so those comments about instead deserializing using a bespoke object can be ignored. that would be for another PR or for a maintainer of the platform (eg. @smartcmd) to add tbh. |
it would be ideal if all the formatting changes could be reverted so that it's only code changes. |
Another thing is you have to pin a version of allay instead of rolling release |
yeah, I mentioned that in one of the comments |
I will create another branch for refactoring this code and accepting |
Adapt Allay materials update and update to the latest minecraft version