Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adapt allay update #484

Open
wants to merge 7 commits into
base: ver/6.6.0
Choose a base branch
from

Conversation

IWareQ
Copy link

@IWareQ IWareQ commented Dec 16, 2024

Adapt Allay materials update and update to the latest minecraft version

* feat: update mapping files to latest
@@ -13,7 +13,7 @@ object Versions {
const val caffeine = "3.1.8"

const val slf4j = "2.0.16"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reformat code to remove this

platforms/allay/src/main/resources/mapping/biomes.json Outdated Show resolved Hide resolved
Comment on lines 193 to 194
return JeBlockState.create((String) data.get("Name"),
new TreeMap<>((Map<String, String>) data.getOrDefault("Properties", Map.of())));
Copy link
Member

@solonovamax solonovamax Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this two lines instead of one?
and if it's too long to fit on a single line, it should really be

        return JeBlockState.create(
            (String) data.get("Name"),
            new TreeMap<>((Map<String, String>) data.getOrDefault("Properties", Map.of()))
        );

(or whatever the code formatted with the editorconfig file applied is)

object CLI {
const val logback = "1.5.8"
const val picocli = "4.7.6"
}

object Allay {
const val api = "0114e0b290"
const val api = "master-SNAPSHOT"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a specific version rather than master-SNAPSHOT, to ensure reproducibility (ie. if someone 5 years from now tries to build it, it should still build just fine & should produce the same output)

@solonovamax
Copy link
Member

solonovamax commented Dec 16, 2024

ah, you're not the person who originally added the allay platform, so those comments about instead deserializing using a bespoke object can be ignored.

that would be for another PR or for a maintainer of the platform (eg. @smartcmd) to add tbh.

@solonovamax
Copy link
Member

it would be ideal if all the formatting changes could be reverted so that it's only code changes.
only apply formatting to the bits that you changed.

@duplexsystem
Copy link
Member

Another thing is you have to pin a version of allay instead of rolling release

@solonovamax
Copy link
Member

Another thing is you have to pin a version of allay instead of rolling release

yeah, I mentioned that in one of the comments

@IWareQ
Copy link
Author

IWareQ commented Dec 17, 2024

it would be ideal if all the formatting changes could be reverted so that it's only code changes. only apply formatting to the bits that you changed.

I will create another branch for refactoring this code and accepting .editorconfig styles.

@IWareQ IWareQ requested a review from solonovamax December 17, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants