Add seL4_WordBits type for arm target #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables our default root-task to build with the `arm-sel4-helios` target. Since bindgen doesn't seem to expand function like macros, this gets us by for now. Relates to #18
|
Is this a bad idea? |
|
Hmm, considering that there's a relatively high cost of remediation suggested in the underlying rust-cexpr issue ( jethrogb/rust-cexpr#3 (comment) ) , it looks like we're going to have to come to terms with some sort of compromise here. A large comment with links to the associated issues is probably a step in the direction of making this less likely to be a forgotten pain point, at least. |
ZackPierce
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables our default root-task to build with the
arm-sel4-heliostarget.Since bindgen doesn't seem to expand function like macros, this gets us by for now.
Relates to #18