Improve repo style, interface and add UK local authority breakdowns #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into dev-improv-2
The existing type hints in simulation.py are incorrect. This attempts to fix them (And associated issues found while doing that), but I had to use # type:ignore in one place related to where we are trying to work on microsimulation and simulation in the same code even though only some of it applies to microsimulations. Do not merge as-is, this commit is at-request to show current progress
anth-volk
requested changes
Dec 10, 2024
There was a problem hiding this comment.
I'm trying out Conventional Comments (link) in this review; feel free to let me know what you think.
There are only two blocking comments I had, one due to a potential error driven by referential equality and one around whether or not the docs successfully built. I've left various other nitpicks and suggestions, but I don't think these are vital to address in this PR, especially if (as it seems) this is majorly blocking for the local area constituency work.
policyengine/outputs/household/comparison/axes/variation_chart.py
Outdated
Show resolved
Hide resolved
policyengine/outputs/household/comparison/axes/variation_chart.py
Outdated
Show resolved
Hide resolved
nikhilwoodruff
changed the title
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61