Fix invalid value error in weekly_hours_worked file by using np.divide #5505
+83
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with out and where parameters
MaxGhenis
requested changes
Jan 23, 2025
| lsr_relative_change = np.divide( | ||
| income_effect, | ||
| original_earnings, | ||
| out=np.zeros_like( |
There was a problem hiding this comment.
To avoid awkward line breaks.
Suggested change
| out=np.zeros_like( | |
| # Assign no LSR change to people with no original earnings to avoid dividing by zero. | |
| out=np.zeros_like(income_effect, dtype=np.float32), | |
| where=original_earnings != 0, |
There was a problem hiding this comment.
Try make format and please add the comment I suggested
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5505 +/- ##
==========================================
- Coverage 99.12% 99.10% -0.03%
==========================================
Files 2592 2679 +87
Lines 37707 38827 +1120
Branches 162 168 +6
==========================================
+ Hits 37378 38478 +1100
- Misses 297 315 +18
- Partials 32 34 +2 ☔ View full report in Codecov by Sentry. |
MaxGhenis
requested changes
Jan 24, 2025
MaxGhenis
changed the title
MaxGhenis
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #4889 and #4890 (Used np.divide NumPy function with out and where parameters to solve invalid value encountered when dividing income_effect by original_earnings and dividing substitution_effect by original_earnings in weekly hours worked calculation in weekly hours worked file.)