South Carolina sales tax cut for people age 85 and older #5428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5428 +/- ##
=======================================
Coverage 99.04% 99.05%
=======================================
Files 2679 2682 +3
Lines 38827 38865 +38
Branches 168 168
=======================================
+ Hits 38458 38496 +38
Misses 335 335
Partials 34 34 ☔ View full report in Codecov by Sentry. |
PavelMakarchuk
requested changes
Jan 3, 2025
changelog_entry.yaml
Outdated
There was a problem hiding this comment.
its a good start, we will need to add the general SC use / Sales tax structure as well.
policyengine_us/parameters/gov/states/sc/tax/sales/exclusion/age_threshold.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/sc/tax/sales/exclusion/age_threshold.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/sc/tax/sales/exclusion/age_threshold.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/sc/tax/sales/exclusion/percentage.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/sc/tax/sales/exclusion/percentage.yaml
Outdated
Show resolved
Hide resolved
PavelMakarchuk
requested changes
Jan 27, 2025
policyengine_us/parameters/gov/states/sc/tax/sales_and_use/exclusion/age_threshold.yaml
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/sc/tax/sales_and_use/exclusion/percentage.yaml
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/sc/tax/sales_and_use/exclusion/percentage.yaml
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/sc/tax/sales_and_use/general.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/sc/tax/sales_and_use/general.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/sc/tax/sales_and_use/general.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/sc/tax/sales_and_use/sc_sales_and_purchases_proceeds.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Does this apply to the whole unit?
For example, if there are two people in the tax unit and only one is 85 or over, does the exclusion apply only to that person's portion of purchase proceeds or is it the whole?
policyengine_us/variables/gov/states/sc/tax/sales_and_use/sc_sales_and_use_tax.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5387