Apply five year forward checks with utility function #5175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelMakarchuk
requested changes
Oct 16, 2024
|
The latest changes seemed to break all of the test - please take a look |
Not sure why the changes broke some of the tests but will look into them |
This reverts commit fb07a46.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5175 +/- ##
==========================================
- Coverage 99.12% 99.00% -0.12%
==========================================
Files 2592 2613 +21
Lines 37707 38052 +345
Branches 162 165 +3
==========================================
+ Hits 37378 37675 +297
- Misses 297 344 +47
- Partials 32 33 +1 ☔ View full report in Codecov by Sentry. |
|
Decided to revert all changes so far, start over, and make changes progressively. |
|
Need to resolve merge conflicts - we deleted the dc ctc reform |
There was a problem hiding this comment.
is it possible to test this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5136: applying five year forward checks with a utility function.