Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix YAML tests don't fill Simulation.input_variables #122 #123

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fix YAML tests don't fill Simulation.input_variables #122 #123

merged 1 commit into from
Oct 5, 2023

Conversation

nikhilwoodruff
Copy link
Contributor

@nikhilwoodruff nikhilwoodruff commented Oct 5, 2023 •
edited by MaxGhenis
Loading

Fixes #122

@nikhilwoodruff nikhilwoodruff self-assigned this Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (bf2430d) 83.26% compared to head (04945f4) 83.26%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   83.26%   83.26%           
=======================================
  Files         182      182           
  Lines        8700     8702    +2     
  Branches     1081     1082    +1     
=======================================
+ Hits         7244     7246    +2     
  Misses       1204     1204           
  Partials      252      252
Files Coverage Δ
...olicyengine_core/simulations/simulation_builder.py 89.27% <100.00%> (+0.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikhilwoodruff nikhilwoodruff merged commit 5c5e636 into master Oct 5, 2023
6 checks passed
@nikhilwoodruff nikhilwoodruff deleted the yaml-bug-fix branch October 5, 2023 13:23
@MaxGhenis MaxGhenis linked an issue Oct 5, 2023 that may be closed by this pull request
YAML tests don't fill Simulation.input_variables #122
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikhilwoodruff nikhilwoodruff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YAML tests don't fill Simulation.input_variables
1 participant
@nikhilwoodruff