Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yukon-Basic-Personal-Amount #441

Closed
wants to merge 24 commits into from
Closed

Yukon-Basic-Personal-Amount #441

wants to merge 24 commits into from

Conversation

sqw0418
Copy link
Contributor

@sqw0418 sqw0418 commented Sep 11, 2023

Fixes #312

RuoqiTan and others added 15 commits May 29, 2023 22:25
@PavelMakarchuk PavelMakarchuk marked this pull request as ready for review October 18, 2023 22:41
MaxGhenis
MaxGhenis requested changes Oct 20, 2023
View reviewed changes
policyengine_canada/variables/gov/provinces/yt/tax/income/yt_basic_personal_amount.py
period
).gov.provinces.yt.tax.income.credits.basic_personal_amount

applicable_amount = p.applicable_amount
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need these - just use p. in the calculation

policyengine_canada/variables/gov/provinces/yt/tax/income/yt_basic_personal_amount.py
)
additional_amount_eligible = additional_amount <= 0

return where(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate these into two variables yt_basic_personal_amount_{base,additional} and then have this use adds

.../parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/applicable_amount.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move these three files into a new additional folder

.../parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/applicable_amount.yaml
@@ -0,0 +1,15 @@
description: Yukon reduces this basic personal amount, for high income filers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the amount of the additional bpa?

...ine_canada/parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/divisor.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the phase-out width

PavelMakarchuk
PavelMakarchuk requested changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Max left comments, I dont see any commits resolving those

@yy3187 yy3187 mentioned this pull request May 7, 2024
Closed
@PavelMakarchuk
Copy link
Collaborator

Duplicate of #490

@PavelMakarchuk PavelMakarchuk marked this as a duplicate of #490 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavelMakarchuk PavelMakarchuk PavelMakarchuk requested changes

@MaxGhenis MaxGhenis MaxGhenis requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Yukon basic personal amount
4 participants
@sqw0418 @PavelMakarchuk @MaxGhenis @RuoqiTan