Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manitoba personal tax credit #401

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

laviniawo
Copy link
Contributor

Fixes #400

Tests and changelog to be done

@laviniawo laviniawo marked this pull request as ready for review July 18, 2023 01:09
values:
2022-01-01: 113
metadata:
unit: currency-CAD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
unit: currency-CAD
unit: currency-CAD
period: year

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

off yaml files that need it

from policyengine_canada.model_api import *


class born_year(Variable):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class born_year(Variable):
class birth_year(Variable):

class born_year(Variable):
value_type = int
entity = Person
label = "Born year"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label = "Born year"
label = "Persons' birth year"

value_type = int
entity = Person
label = "Born year"
documentation = "The year of the person was born"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
documentation = "The year of the person was born"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the personal_tax_credit folder to personal

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this file to amount.yaml

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make a age_threshold folder and rename this file elderly

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this file to teen in the age_threshold folder

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make a folder called amount and organize the folder based on their dependence, this should be basic.yaml etc.

2022-01-01: 2004
metadata:
unit: year
label: Manitoba teenage tax credit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewrite the labels to
Manitoba {name of credit} {purpose of file}

f.e.
Manitoba personal tax credits age credit amount

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all yaml files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manitoba Personal Tax Credit
2 participants