-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manitoba personal tax credit #401
base: master
Are you sure you want to change the base?
Conversation
...ne_canada/parameters/gov/provinces/mb/tax/income/credits/personal_tax_credit/age_credit.yaml
Outdated
Show resolved
Hide resolved
...ne_canada/parameters/gov/provinces/mb/tax/income/credits/personal_tax_credit/age_credit.yaml
Outdated
Show resolved
Hide resolved
...a/parameters/gov/provinces/mb/tax/income/credits/personal_tax_credit/elderly_age_amount.yaml
Outdated
Show resolved
Hide resolved
...nada/parameters/gov/provinces/mb/tax/income/credits/personal_tax_credit/teen_age_amount.yaml
Outdated
Show resolved
Hide resolved
...ne_canada/parameters/gov/provinces/mb/tax/income/credits/personal_tax_credit/age_credit.yaml
Outdated
Show resolved
Hide resolved
...a/parameters/gov/provinces/mb/tax/income/credits/personal_tax_credit/elderly_age_amount.yaml
Outdated
Show resolved
Hide resolved
.../variables/gov/provinces/mb/tax/income/credits/personal_tax_credit/mb_personal_tax_credit.py
Outdated
Show resolved
Hide resolved
...variables/gov/provinces/mb/tax/income/credits/personal_tax_credit/mb_spouse_credit_amount.py
Outdated
Show resolved
Hide resolved
values: | ||
2022-01-01: 113 | ||
metadata: | ||
unit: currency-CAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unit: currency-CAD | |
unit: currency-CAD | |
period: year |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
off yaml files that need it
from policyengine_canada.model_api import * | ||
|
||
|
||
class born_year(Variable): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class born_year(Variable): | |
class birth_year(Variable): |
class born_year(Variable): | ||
value_type = int | ||
entity = Person | ||
label = "Born year" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
label = "Born year" | |
label = "Persons' birth year" |
value_type = int | ||
entity = Person | ||
label = "Born year" | ||
documentation = "The year of the person was born" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
documentation = "The year of the person was born" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename the personal_tax_credit
folder to personal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename this file to amount.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make a age_threshold folder and rename this file elderly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename this file to teen in the age_threshold folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make a folder called amount and organize the folder based on their dependence, this should be basic.yaml etc.
2022-01-01: 2004 | ||
metadata: | ||
unit: year | ||
label: Manitoba teenage tax credit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rewrite the labels to
Manitoba {name of credit} {purpose of file}
f.e.
Manitoba personal tax credits age credit amount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all yaml files
Fixes #400
Tests and changelog to be done