-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manitoba Tuition and Education credit amount #337
Open
laviniawo
wants to merge
33
commits into
PolicyEngine:master
Choose a base branch
from
laviniawo:laviniawo/issue335
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes PolicyEngine#335 -- tests awaiting Co-authored-by: Kingsley Yang <[email protected]>
Fixes PolicyEngine#335 testings done
Shinuing
reviewed
Jun 19, 2023
...parameters/gov/provinces/mb/tax/income/credits/tuition_amount/part_time_students_amount.yaml
Outdated
Show resolved
Hide resolved
...parameters/gov/provinces/mb/tax/income/credits/tuition_amount/part_time_students_amount.yaml
Outdated
Show resolved
Hide resolved
...a/parameters/gov/provinces/mb/tax/income/credits/tuition_amount/eligible_tuition_amount.yaml
Outdated
Show resolved
Hide resolved
...a/parameters/gov/provinces/mb/tax/income/credits/tuition_amount/eligible_tuition_amount.yaml
Outdated
Show resolved
Hide resolved
...parameters/gov/provinces/mb/tax/income/credits/tuition_amount/full_time_students_amount.yaml
Outdated
Show resolved
Hide resolved
...parameters/gov/provinces/mb/tax/income/credits/tuition_amount/full_time_students_amount.yaml
Outdated
Show resolved
Hide resolved
...parameters/gov/provinces/mb/tax/income/credits/tuition_amount/full_time_students_amount.yaml
Outdated
Show resolved
Hide resolved
...s/gov/provinces/mb/tax/income/credits/tuition_amount/part_time_disabled_students_amount.yaml
Outdated
Show resolved
Hide resolved
...s/gov/provinces/mb/tax/income/credits/tuition_amount/part_time_disabled_students_amount.yaml
Outdated
Show resolved
Hide resolved
...parameters/gov/provinces/mb/tax/income/credits/tuition_amount/part_time_students_amount.yaml
Outdated
Show resolved
Hide resolved
...s/gov/provinces/mb/tax/income/credits/tuition_amount/part_time_disabled_students_amount.yaml
Outdated
Show resolved
Hide resolved
...parameters/gov/provinces/mb/tax/income/credits/tuition_amount/part_time_students_amount.yaml
Outdated
Show resolved
Hide resolved
...parameters/gov/provinces/mb/tax/income/credits/tuition_amount/part_time_students_amount.yaml
Outdated
Show resolved
Hide resolved
…-canada into laviniawo/issue335
…dits/tuition_amount/part_time_students_amount.yaml Co-authored-by: Pavel Makarchuk <[email protected]>
…dits/tuition_amount/eligible_tuition_amount.yaml Co-authored-by: Pavel Makarchuk <[email protected]>
…dits/tuition_amount/eligible_tuition_amount.yaml Co-authored-by: Pavel Makarchuk <[email protected]>
…dits/tuition_amount/full_time_students_amount.yaml Co-authored-by: Pavel Makarchuk <[email protected]>
…dits/tuition_amount/full_time_students_amount.yaml Co-authored-by: Pavel Makarchuk <[email protected]>
…dits/tuition_amount/full_time_students_amount.yaml Co-authored-by: Pavel Makarchuk <[email protected]>
…-canada into laviniawo/issue335
...canada/parameters/gov/provinces/mb/tax/income/credits/tuition_amount/part_time/disabled.yaml
Outdated
Show resolved
Hide resolved
..._canada/parameters/gov/provinces/mb/tax/income/credits/tuition_amount/tuition_threshold.yaml
Outdated
Show resolved
Hide resolved
...bles/gov/provinces/mb/tax/income/credits/tuition_amount/mb_tuition_amount_credit_eligible.py
Outdated
Show resolved
Hide resolved
...bles/gov/provinces/mb/tax/income/credits/tuition_amount/mb_tuition_amount_credit_eligible.py
Outdated
Show resolved
Hide resolved
...anada/tests/gov/provinces/mb/tax/income/credits/tuition_amount/mb_tuition_amount_credit.yaml
Outdated
Show resolved
Hide resolved
…-canada into laviniawo/issue335
PavelMakarchuk
approved these changes
Sep 27, 2023
Shinuing
approved these changes
Sep 27, 2023
MaxGhenis
requested changes
Sep 29, 2023
...canada/parameters/gov/provinces/mb/tax/income/credits/tuition_amount/part_time/disabled.yaml
Outdated
Show resolved
Hide resolved
..._canada/parameters/gov/provinces/mb/tax/income/credits/tuition_amount/tuition_threshold.yaml
Outdated
Show resolved
Hide resolved
...ada/variables/gov/provinces/mb/tax/income/credits/tuition_amount/mb_tuition_amount_credit.py
Outdated
Show resolved
Hide resolved
…-canada into laviniawo/issue335
PavelMakarchuk
approved these changes
Nov 27, 2023
MaxGhenis
requested changes
Dec 10, 2023
...parameters/gov/provinces/mb/tax/income/credits/tuition_amount/amount/part_time/disabled.yaml
Outdated
Show resolved
Hide resolved
period | ||
).gov.provinces.mb.tax.income.credits.tuition_amount | ||
|
||
tuition = person("tuition_expenses", period) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the legal code says it's divided by the lowest federal marginal rate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The legal code differes from the form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #335