-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API screenshot on homepage. #834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Unfortunately, I fear this does the opposite of what #215 is looking for - what we're hoping to do is change the font of the code output screen on that page so that it uses a monospace font like Courier instead of the Arial or Helvetica it's currently using. The image on the homepage is actually correct; the item with the font issue has moved from the pre-redesign homepage to a new API page, which may be part of the confusion.
Would you be willing to look into why the API renders this code with the Arial and change it to monospace?
Initial investigation suggests that the code responsible for the font is in the policyengine-api-demo repository: If streamlit is reading that repository, then changing the font there should fix the problem. |
The issue is fixed here. In this PR, I have reverted previous commits and added a comment to help others find the policyengine-api-demo repository. |
Thanks so much. I don't have write access over there, so I linked Nikhil, hopefully he can address at a later point, or if I can be added, I'll check it out a bit later. |
I actually do have write access now. As I mentioned over there in the PR, would you mind uploading an image of the sample API code block with the formatting changes? |
Thanks for this, @abhcs. I approved the fix over at |
Fix #215 by updating the API screenshot image file rendered on the homepage.
🤖 Generated by Copilot at 206ca95
Summary
Walkthrough