Make you are here on household charts a point instead of line

[patrickhanl]

Fixes #611

🤖 Generated by Copilot at e7e3b65

Summary

🧪📊🛠️

This pull request enhances the BaselineAndReformChart component, which shows the impact of policy reforms on a household's income. It adds a baseline prop, switches to scatter traces, and updates the hover card. It also adds a test file for the component, which checks the toggle button.

BaselineAndReformChart shows us the fate
Of the households under different policies
We mock the api and the plotly trace
To test the toggle and the hover messages

Walkthrough

• Add a new prop baselineValue to BaselineAndReformTogetherPlot component to show the baseline value on the chart (link)
• Replace line traces with scatter traces for the current and baseline values of the variable in BaselineAndReformTogetherPlot component to improve the plot appearance and clarity (link)
• Adjust the hover card message for the points on BaselineAndReformTogetherPlot component to indicate whether they belong to the reform or the baseline scenario (link)
• Replace line trace with scatter trace for the change in the variable value in BaselineReformDeltaPlot component to improve the plot appearance and clarity (link)
• Add a test file BaselineAndReformChart.test.js for the BaselineAndReformChart component, which checks the toggle button functionality using a mock metadata object and api functions (link)

Changed the baseline and reform comparison charts to have separate points for baseline and reform based on current variable value.

They appear in the legend by default so I left them in for now but can take out if not needed.

Also added test cases.

[MaxGhenis]

Thank you @patrickhanl! The baseline and reform view looks perfect. On the difference plot, could you remove the line from the legend entry for the you are here series? Also could you show a screenshot of a scenario without a reform?

[patrickhanl]

Thank you @patrickhanl! The baseline and reform view looks perfect. On the difference plot, could you remove the line from the legend entry for the you are here series? Also could you show a screenshot of a scenario without a reform?

@MaxGhenis , I wasn't sure if you wanted the baseline only updated since it doesn't have the issue of multiple lines, so that looks the same (see below). I can make that update pretty quickly if you want it updated as well. I'll push the legend update with that if so.

[MaxGhenis]

yes please do it for baseline only as well

[patrickhanl]

@MaxGhenis please see screenshots below with hovercards for updated plots. Let me know if you see anything else that needs to be fixed. Not sure exactly why the CI check is failing? Looks like the request to the Node server is failing?

Baseline and Reform together plot

Baseline and Reform delta plot

Baseline only plot

[MaxGhenis]

Thanks @patrickhanl, all looks good here. Just looks like a nodejs.org issue holding back the CI: nodejs/nodejs.org#4495 (comment)

[MaxGhenis]

The nodejs.org issue resolved itself, so merging. Thanks!