Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom baseline MTR charts #631

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Fix custom baseline MTR charts #631

merged 1 commit into from
Aug 2, 2023

Conversation

nikhilwoodruff
Copy link
Contributor

@nikhilwoodruff nikhilwoodruff commented Aug 2, 2023 •
edited by ghost
Loading

Fixes PolicyEngine/policyengine-api#631

🤖 Generated by Copilot at 6b859a8

Summary

🎣📊📋

Updated MarginalTaxRatesChart to use policy data from usePolicyEngine hook. This enables the chart to show how the baseline policy affects marginal tax rates.

We use the usePolicyEngine hook
To unleash the power of the policy prop
We calculate the marginal tax rates
And chart the doom of the wealthy fates

Walkthrough

  • Pass baseline policy data to MarginalTaxRatesChart component as a prop (link)
  • Remove empty line for code readability (link)

@nikhilwoodruff nikhilwoodruff self-assigned this Aug 2, 2023
@nikhilwoodruff nikhilwoodruff merged commit 1419f7a into master Aug 2, 2023
3 checks passed
@MaxGhenis MaxGhenis deleted the mtr-diff-custom-baseline branch August 2, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikhilwoodruff nikhilwoodruff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Marginal tax rate difference doesn't work with a custom baseline
1 participant
@nikhilwoodruff