-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinity inputs #2103
Merged
anth-volk
merged 20 commits into
PolicyEngine:master
from
anth-volk:feat/2095-infinity-input
Oct 17, 2024
Merged
Infinity inputs #2103
anth-volk
merged 20 commits into
PolicyEngine:master
from
anth-volk:feat/2095-infinity-input
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhilwoodruff
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge after adding shading to the open/collapse button, and passing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2095
Changes
PolicyEngine/policyengine-api#1887 must be merged before this.
This PR makes a few relevant changes to enable infinity and -infinity inputs:
Response.json()
, which has no means of specifying a custom reviver, and replaces all uses ofResponse.json()
with the new wrapperStableInputNumber
in theParameterEditor
component with Ant Design'sInputNumber
, then makes the input a controlled input to allow custom updating. This also required some changes to the underlying display logic.There remain four unaddressed issues that I've chosen to leave unaddressed to make sure we can push this as quickly as possible. If pushed, I can address these at a different time:
Infinity
; for some reason, instead of displaying the infinity symbol, it will display "Infinity," and there are some quirks around that, as well.I have also tested manually that this does generate a response from the back end when running locally with the required API changes. That said, I had no value to test against, so am unclear on the accuracy of the output.
Screenshots
AwesomeScreenshot-10_17_2024.12_57_25AM.mp4
Tests
None have been added.