Re-enable cliff impacts #1845
Draft
Re-enable cliff impacts #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you show the hover? I'm curious what we show as the baseline cliff rates. |
|
Just tried locally and getting these results. Something is off in our calculation, should be at least 1%. @nikhilwoodruff should we refactor using the new MTR code for LSRs? Baseline for 2024:
|
|
Ah, yes we should which will probably block this for at least a couple of weeks. |
|
@MaxGhenis Wanted to check if this is desired at all |
|
Could we check the numbers again? |
|
Sure, will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1843.
Fixes #1844.
Changes
This PR re-enables cliff impacts and removes the hanging semicolon present due to a syntax error in
PolicyOutput.jsx.Screenshots
AwesomeScreenshot-5_31_2024.7.49.51PM.mp4
Tests
N/A