Merge pull request #2041 from bharateshwq/undefined-vars-marginalTaxR…

…ates solves undefined variable employment_income error in Marginal tax Rates
PolicyEngine · Oct 15, 2024 · 7f49e72 · 7f49e72
2 parents 1a491ff + 96527fc
commit 7f49e72
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/api/variables.js b/src/api/variables.js
@@ -356,7 +356,7 @@ export function getValueFromHousehold(
   }
   if (!timePeriodValues) {
     console.error("Error getting variable value", variable);
-    return null;
+    return 0;
   }
   if (!timePeriod) {
     const possibleTimePeriods = Object.keys(timePeriodValues);

diff --git a/src/pages/household/output/MarginalTaxRates.jsx b/src/pages/household/output/MarginalTaxRates.jsx
@@ -51,6 +51,7 @@ export default function MarginalTaxRates(props) {
     householdInput,
     metadata,
   );
+
   const currentMtr = getValueFromHousehold(
     "marginal_tax_rate",
     year,
@@ -61,7 +62,12 @@ export default function MarginalTaxRates(props) {
 
   useEffect(() => {
     let householdData = JSON.parse(JSON.stringify(householdInput));
+    // Ensure 'employment_income' exists for the current user and initialize if necessary
+    householdData.people.you = householdData.people.you || {};
+    householdData.people.you.employment_income =
+      householdData.people.you.employment_income || {};
     householdData.people.you.employment_income[year] = null;
+
     householdData.axes = [
       [
         {