Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chunking #1951

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Remove chunking #1951

merged 1 commit into from
Nov 6, 2024

Conversation

nikhilwoodruff
Copy link
Collaborator

Fixes #1950

@nikhilwoodruff nikhilwoodruff added the bug Something isn't working label Nov 6, 2024
@nikhilwoodruff nikhilwoodruff self-assigned this Nov 6, 2024
@anth-volk
Copy link
Collaborator

I just want to run this locally against the erroneous policy to be 100% sure (other approach that wouldn't require this could be just to literally roll back), but this all looks good to me.

@anth-volk
Copy link
Collaborator

When running this locally, I'm actually having difficulty getting the worker to properly initialize. In case it's just something local, and considering the importance, @nikhilwoodruff I'm going to merge this, but I think if this crashes out, we should instead roll this and the PR creating it back, so back to 4546ddb.

@anth-volk anth-volk merged commit e077bd2 into master Nov 6, 2024
4 checks passed
@anth-volk anth-volk deleted the nikhilwoodruff/issue1950 branch November 6, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chunking appears to cause no-impacts.
2 participants