Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add loading state to button #118

Merged
merged 4 commits into from
Nov 12, 2024
Merged

feat: add loading state to button #118

merged 4 commits into from
Nov 12, 2024

Conversation

joshuagraber
Copy link
Collaborator

Add loading UI to button component

Background

  • Rather than repeat loading state with every instance, we add it here.

Description

  • Adds loading UI to button when isLoading prop is truthy
  • Spinner is default, but it will render slot content instead if passed.

Acceptance Criteria

  1. Run demo app, hard code isLoading prop of one of the buttons to be true, observe.

@joshuagraber joshuagraber self-assigned this Nov 12, 2024
@joshuagraber joshuagraber merged commit 7ace5f7 into beta Nov 12, 2024
5 checks passed
@joshuagraber joshuagraber deleted the feat/button-loading-state branch November 12, 2024 19:08
@joshuagraber joshuagraber mentioned this pull request Nov 12, 2024
Merged
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.1.0-beta.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshuagraber joshuagraber

Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joshuagraber