Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graffiti centers on where you click. #9255

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

Mechoid
Copy link
Contributor

@Mechoid Mechoid commented Sep 26, 2023

Tin.
Persisting graffiti will also save its pixel shift.

@Cerebulon
Copy link
Contributor

Cerebulon commented Sep 27, 2023

You're doing half of this in two different places.

/obj/effect/decal/cleanable/crayon (Crayon doodles), where you've applied the "appears where you click" feature is a distinct thing from /obj/effect/decal/writing (Engraved graffiti).

Crayon doodles are handled by the Filth persistence system, so you'll need to include the pixel x/y save/load there.
Engraved graffiti (the Graffiti persistence system) will need the on-click positioning where it's handled, probably on turf/proc/try_graffiti
For engraved graffiti you'd also need to remove the built-in offset on the icons since it currently randomly placed it on the tile by using one of like 4 icons which are pre-placed in corners of tiles.

@MistakeNot4892
Copy link
Contributor

The graffiti icons are also arranged as they are so that a full turf doesn't have overlapping graffiti.

@Mechoid
Copy link
Contributor Author

Mechoid commented Oct 7, 2023

Overlapping engravings aren't too much of an issue in my opinion, as if they get to the point of being obstructive somehow, Engineering should already have been notified of their presence.

@Spookerton Spookerton added the Feature Tweak The PR changes an existing feature in a small way. label Oct 10, 2023
Comment on lines 10 to 14
. = "<td colspan = 3>[thing]</td><td>Loc:([CRAY.x],[CRAY.y],[CRAY.z]) P_X: [CRAY.pixel_x] P_Y: [CRAY.pixel_y] Color: [CRAY.art_color] Shading: [CRAY.art_shade] Type: [CRAY.art_type]</td><td><a href='byond://?src=\ref[src];caller=\ref[user];remove_entry=\ref[thing]'>Destroy</a></td>"
else
. = "<td colspan = 4>[thing]</td>"
else
return null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. = "<td colspan = 3>[thing]</td><td>Loc:([CRAY.x],[CRAY.y],[CRAY.z]) P_X: [CRAY.pixel_x] P_Y: [CRAY.pixel_y] Color: [CRAY.art_color] Shading: [CRAY.art_shade] Type: [CRAY.art_type]</td><td><a href='byond://?src=\ref[src];caller=\ref[user];remove_entry=\ref[thing]'>Destroy</a></td>"
else
. = "<td colspan = 4>[thing]</td>"
else
return null
return "<td colspan = 3>[thing]</td><td>Loc:([CRAY.x],[CRAY.y],[CRAY.z]) P_X: [CRAY.pixel_x] P_Y: [CRAY.pixel_y] Color: [CRAY.art_color] Shading: [CRAY.art_shade] Type: [CRAY.art_type]</td><td><a href='byond://?src=\ref[src];caller=\ref[user];remove_entry=\ref[thing]'>Destroy</a></td>"
return "<td colspan = 4>[thing]</td>"
return null

@Atermonera Atermonera merged commit e976eab into PolarisSS13:master Dec 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Tweak The PR changes an existing feature in a small way.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants