Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a search parameter on getCards() #8

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Allow a search parameter on getCards() #8

wants to merge 6 commits into from

Conversation

JayHors
Copy link

@JayHors JayHors commented Dec 8, 2022

This lets you add a search parameter to the getCards() method by using a named parameter. Currently adding error handling, but wanted to get this out of the way now.

@JayHors
Copy link
Author

JayHors commented Dec 8, 2022

This will require the end user to follow the conventions listed at https://docs.pokemontcg.io/api-reference/cards/search-cards/ to search.

@JayHors JayHors marked this pull request as ready for review December 8, 2022 21:58
@PureTryOut
Copy link

Is there any reason this isn't merged yet @JayHors? I'd like to use this SDK but not having this feature makes it a bit... cumbersome to say the least.

PureTryOut
PureTryOut suggested changes May 23, 2023
View reviewed changes
lib/src/pokemon_tcg.dart Outdated Show resolved Hide resolved
@JayHors
Copy link
Author

JayHors commented May 23, 2023

Is there any reason this isn't merged yet @JayHors? I'd like to use this SDK but not having this feature makes it a bit... cumbersome to say the least.

Not sure yet, I'm not a maintainer of the repo, so I don't have merge perms.

@PureTryOut
Copy link

Ah sorry, that was a wrong assumption on my part.

@GroovinChip any chance this could be merged?

PureTryOut
PureTryOut suggested changes May 23, 2023
View reviewed changes
lib/src/pokemon_tcg.dart Outdated Show resolved Hide resolved
@GroovinChip
Copy link
Collaborator

Apologies, folks, I've had no bandwidth for the last few months. I'll review this now.

GroovinChip
GroovinChip requested changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@GroovinChip GroovinChip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please just update the version in pubspec.yaml and add a changelog entry. Thanks!

@JayHors
Copy link
Author

JayHors commented Oct 3, 2023

@GroovinChip sorry for the severe delay, similar personal bandwidth issues. Just got the changes requested pushed.

@GroovinChip GroovinChip self-requested a review October 3, 2023 19:53
GroovinChip
GroovinChip approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@GroovinChip GroovinChip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@GroovinChip
Copy link
Collaborator

@JayHors looks like the check failed because the http package needs to be updated.

@PureTryOut
Copy link

@GroovinChip could you merge this?

@GroovinChip
Copy link
Collaborator

@GroovinChip could you merge this?

Not yet, the failing check needs to be addressed

@PureTryOut
Copy link

It's been so long that we can't see the output of that CI any more, could you re-run it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PureTryOut PureTryOut PureTryOut requested changes

@GroovinChip GroovinChip GroovinChip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JayHors @PureTryOut @GroovinChip