Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pokemon cries field #155

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Conversation

FallenDeity
Copy link
Contributor

Add cries field to Pokemon model after merge of pr #1030.

  • Example Response
"cries": {
     "latest": "https://raw.githubusercontent.com/PokeAPI/cries/main/cries/pokemon/latest/35.ogg",
     "legacy": "https://raw.githubusercontent.com/PokeAPI/cries/main/cries/pokemon/legacy/35.ogg"
}
  • Field
{
     "name": "cries",
     "description": "A set of cries used to depict this Pokémon in the game. A visual representation of the various cries can be found at <a href='https://github.com/PokeAPI/cries#cries'>PokeAPI/cries</a>",
     "type": "PokemonCries"
}
  • Model
{
    "name":"PokemonCries",
    "fields":[
        {
            "name":"latest",
            "description":"The latest depiction of this Pokémon's cry.",
            "type":"string"
        },
        {
            "name":"legacy",
            "description":"The legacy depiction of this Pokémon's cry.",
            "type":"string"
        }
    ]
}

ImgBotApp and others added 3 commits December 23, 2023 18:33
*Total -- 38.31kb -> 26.44kb (30.99%)

/src/images/pokeapi_256.png -- 14.74kb -> 5.52kb (62.53%)
/src/images/placeholder.png -- 1.71kb -> 0.96kb (43.71%)
/public/pokeapi_192_square.png -- 21.35kb -> 19.45kb (8.91%)
/src/images/ex.svg -- 0.51kb -> 0.50kb (1.34%)

Signed-off-by: ImgBotApp <[email protected]>
@Naramsim
Copy link
Member

Hi, can you get rid of all the images?

@FallenDeity
Copy link
Contributor Author

Aight, will do.

@FallenDeity
Copy link
Contributor Author

@Naramsim done

@Naramsim Naramsim merged commit ea608d3 into PokeAPI:master Feb 13, 2024
@Naramsim
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants