Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Offset Arrays back as a dependency #197

Merged
merged 9 commits into from
Aug 31, 2023
Merged

Conversation

gottacatchenall
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -4.94% ⚠️

Comparison is base (dd9248f) 53.36% compared to head (f8f66ba) 48.43%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
- Coverage   53.36%   48.43%   -4.94%     
==========================================
  Files          59       50       -9     
  Lines        1692     1501     -191     
==========================================
- Hits          903      727     -176     
+ Misses        789      774      -15     
Flag Coverage Δ
unittests 48.43% <0.00%> (-4.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/SpeciesDistributionToolkit.jl 100.00% <ø> (ø)
src/pseudoabsences.jl 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpoisot
Copy link
Member

tpoisot commented Aug 29, 2023

OK let's see if this builds the documentation, and then I'll tag a new release

@tpoisot
Copy link
Member

tpoisot commented Aug 29, 2023

I'm tempted to see what the Phylopic issue is before I merge.

@gottacatchenall
Copy link
Member Author

A retry worked, a few things on Github's servers have been particularly shit today so could be an issue with their CI

@gottacatchenall
Copy link
Member Author

Yeah looks like PhyloPic works

@tpoisot tpoisot merged commit 1cf628b into main Aug 31, 2023
7 of 8 checks passed
@tpoisot tpoisot deleted the mdc/withinradius_performance branch August 31, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants