Support Literal and Union/Optional types on structs. Fixes #405 #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomecek
force-pushed
the
pit/literal
branch
2 times, most recently
from
a174b05 to
43b9e0c
Compare
ptomecek
requested review from
robambalu,
AdamGlustein,
svatasoiu and
alexddobkin
as code owners
AdamGlustein
reviewed
Dec 4, 2024
Signed-off-by: Pascal Tomecek <[email protected]>
AdamGlustein
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405.
In particular, since the type annotations are preserved when calling
.metadata(typed=True), they can then be used for runtime validation, which would not be the case if "str" (in the case of Literal) or object (in the case of Union) was used directly, Of course, by using Union one loses the benefits of being able to operate on the data in C++, but this is already true of "object", so the validation capabilities are a strict improvement.