Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from bump2version to bump-my-version #315

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Move from bump2version to bump-my-version #315

merged 1 commit into from
Nov 8, 2024

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Jul 9, 2024 •
edited
Loading

  • Move from deprecated bump2version to active bump-my-version
  • Make sure dependabot puts the right labels in place, add python

needs #314

@timkpaine timkpaine added the tag: internal Issues and PRs for maintainance of the project - not interesting to external users label Jul 9, 2024
@timkpaine timkpaine marked this pull request as ready for review July 11, 2024 03:18
alexddobkin
alexddobkin previously approved these changes Jul 11, 2024
View reviewed changes
robambalu
robambalu previously approved these changes Jul 11, 2024
View reviewed changes
@robambalu
Copy link
Collaborator

Are we waiting on anything to merge this?

@timkpaine
Copy link
Member Author

Are we waiting on anything to merge this?

waiting to synchronize across the smaller, lower impact repos on the org first. will do this weekend

@timkpaine timkpaine dismissed stale reviews from robambalu and alexddobkin via 57d0aea August 9, 2024 23:14
@arhamchopra arhamchopra mentioned this pull request Aug 26, 2024
Merged
@ptomecek
Copy link
Collaborator

ptomecek commented Oct 8, 2024

Are we waiting on anything to merge this?

waiting to synchronize across the smaller, lower impact repos on the org first. will do this weekend

I feel like we've been using bump-my-version for awhile now without problems. Is this ready to merge?

@timkpaine timkpaine merged commit 884984c into main Nov 8, 2024
30 checks passed
@timkpaine timkpaine deleted the tkp/bmv branch November 8, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robambalu robambalu robambalu approved these changes

@ptomecek ptomecek ptomecek approved these changes

@alexddobkin alexddobkin alexddobkin left review comments

@AdamGlustein AdamGlustein Awaiting requested review from AdamGlustein AdamGlustein is a code owner

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@czgdp1807 czgdp1807 Awaiting requested review from czgdp1807

Assignees
No one assigned
Labels
tag: internal Issues and PRs for maintainance of the project - not interesting to external users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timkpaine @robambalu @ptomecek @alexddobkin