expose engine shutdown to adapter manager and push/pushpull adapters #312

argaj · 2024-07-03T15:28:34Z

Closes #245

cpp/csp/python/Exception.h

cpp/csp/python/PyAdapterManager.cpp

cpp/csp/python/Exception.h

cpp/csp/python/PyPushInputAdapter.cpp

csp/tests/impl/test_pushadapter.py

csp/tests/impl/test_pushpulladapter.py

csp/tests/test_engine.py

Co-authored-by: Artur Gajowniczek <[email protected]> Signed-off-by: Adam Glustein <[email protected]>

cpp/csp/python/PyAdapterManager.cpp

robambalu

One last thing, we should update the wiki to explain this new functionality too

cpp/csp/python/PyPushInputAdapter.cpp

cpp/csp/python/PyEngine.h

csp/impl/adaptermanager.py

Co-authored-by: Artur Gajowniczek <[email protected]> Signed-off-by: Adam Glustein <[email protected]> Signed-off-by: Gajowniczek, Artur <[email protected]>

Signed-off-by: Gajowniczek, Artur <[email protected]>

…2/csp into ag/expose-engine-shutdown

AdamGlustein · 2024-07-11T18:29:15Z

One last thing, we should update the wiki to explain this new functionality too

@argaj can you make the changes to the wiki explaining this method and commit to this PR branch?

…ine method Signed-off-by: Adam Glustein <[email protected]>

csp/tests/test_engine.py

cpp/csp/python/PyEngine.h

docs/wiki/how-tos/Write-Realtime-Input-Adapters.md

csp/tests/test_engine.py

Signed-off-by: Gajowniczek, Artur <[email protected]>

csp/tests/test_engine.py

…n is passed Signed-off-by: Gajowniczek, Artur <[email protected]>

…engine-shutdown

cpp/csp/python/PyEngine.h

Signed-off-by: Gajowniczek, Artur <[email protected]>

cpp/csp/python/PyAdapterManager.cpp

docs/wiki/how-tos/Write-Realtime-Input-Adapters.md

…, doc fix Signed-off-by: Gajowniczek, Artur <[email protected]>

cpp/csp/python/PyEngine.h

Signed-off-by: Gajowniczek, Artur <[email protected]>

…engine-shutdown Signed-off-by: Gajowniczek, Artur <[email protected]>

cpp/csp/python/PyAdapterManager.cpp

cpp/csp/python/PyEngine.h

AdamGlustein · 2024-07-24T13:17:08Z

When you merge make sure to select "Squash and Merge" and edit the commit message to something succinct, so that it doesn't include all the intermediate commits in the history.

Edit: didn't see Rob's comments just now, address those first.

Signed-off-by: Gajowniczek, Artur <[email protected]>

argaj added the type: enhancement Issues and PRs related to improvements to existing features label Jul 3, 2024

argaj requested review from robambalu, AdamGlustein, svatasoiu and alexddobkin as code owners July 3, 2024 15:28

AdamGlustein requested changes Jul 3, 2024

View reviewed changes

AdamGlustein force-pushed the ag/expose-engine-shutdown branch 2 times, most recently from ec0d10f to 247f831 Compare July 8, 2024 20:09

Expose engine shutdown method for Python push-type adapters

3f2d7b1

Co-authored-by: Artur Gajowniczek <[email protected]> Signed-off-by: Adam Glustein <[email protected]>

AdamGlustein force-pushed the ag/expose-engine-shutdown branch from 247f831 to 3f2d7b1 Compare July 8, 2024 20:15

AdamGlustein self-requested a review July 8, 2024 20:18

argaj force-pushed the ag/expose-engine-shutdown branch from 3f2d7b1 to 35f289a Compare July 9, 2024 13:10

robambalu reviewed Jul 9, 2024

View reviewed changes

cpp/csp/python/PyAdapterManager.cpp Outdated Show resolved Hide resolved

robambalu requested changes Jul 9, 2024

View reviewed changes

cpp/csp/python/PyPushInputAdapter.cpp Outdated Show resolved Hide resolved

cpp/csp/python/PyEngine.h Outdated Show resolved Hide resolved

csp/impl/adaptermanager.py Outdated Show resolved Hide resolved

Expose engine shutdown method for Python push-type adapters

147133c

Co-authored-by: Artur Gajowniczek <[email protected]> Signed-off-by: Adam Glustein <[email protected]> Signed-off-by: Gajowniczek, Artur <[email protected]>

timkpaine force-pushed the ag/expose-engine-shutdown branch from 35f289a to 147133c Compare July 11, 2024 02:05

argaj and others added 2 commits July 11, 2024 09:12

passing exception to engine shutdown wip

84cc40d

Signed-off-by: Gajowniczek, Artur <[email protected]>

Merge branch 'ag/expose-engine-shutdown' of https://github.com/Point7…

d096a88

…2/csp into ag/expose-engine-shutdown

AdamGlustein force-pushed the ag/expose-engine-shutdown branch from 79bf82f to 18631da Compare July 11, 2024 18:30

Create PythonPassthrough exception of proper type in the shutdown_eng…

4ddc99f

…ine method Signed-off-by: Adam Glustein <[email protected]>

AdamGlustein force-pushed the ag/expose-engine-shutdown branch from 18631da to 4ddc99f Compare July 11, 2024 18:32

timkpaine added the tag: needs squash PRs that need to be cleaned/squashed label Jul 11, 2024

robambalu requested changes Jul 12, 2024

View reviewed changes

csp/tests/test_engine.py Show resolved Hide resolved

cpp/csp/python/PyEngine.h Outdated Show resolved Hide resolved

argaj force-pushed the ag/expose-engine-shutdown branch from 58c58b9 to 382321d Compare July 12, 2024 15:24

AdamGlustein requested changes Jul 12, 2024

View reviewed changes

docs/wiki/how-tos/Write-Realtime-Input-Adapters.md Show resolved Hide resolved

csp/tests/test_engine.py Outdated Show resolved Hide resolved

argaj force-pushed the ag/expose-engine-shutdown branch from 382321d to ddd1c3a Compare July 12, 2024 16:20

Add a test for traceback and update wiki

34a1db1

Signed-off-by: Gajowniczek, Artur <[email protected]>

argaj force-pushed the ag/expose-engine-shutdown branch from ddd1c3a to 34a1db1 Compare July 12, 2024 16:26

AdamGlustein requested changes Jul 12, 2024

View reviewed changes

csp/tests/test_engine.py Outdated Show resolved Hide resolved

assert function name in traceback, shutdown engine if not an exceptio…

6a7b202

…n is passed Signed-off-by: Gajowniczek, Artur <[email protected]>

argaj force-pushed the ag/expose-engine-shutdown branch from 3da3626 to 6a7b202 Compare July 16, 2024 12:10

Merge branch 'main' of https://github.com/Point72/csp into ag/expose-…

d076171

…engine-shutdown

AdamGlustein requested changes Jul 17, 2024

View reviewed changes

cpp/csp/python/PyEngine.h Outdated Show resolved Hide resolved

Added shutdown on wrong type to PyEngine_shutdown

b0be488

Signed-off-by: Gajowniczek, Artur <[email protected]>

robambalu requested changes Jul 22, 2024

View reviewed changes

cpp/csp/python/PyAdapterManager.cpp Outdated Show resolved Hide resolved

cpp/csp/python/PyAdapterManager.cpp Outdated Show resolved Hide resolved

docs/wiki/how-tos/Write-Realtime-Input-Adapters.md Outdated Show resolved Hide resolved

clearer error msg, move creating exception logic to separate function…

ad58a75

…, doc fix Signed-off-by: Gajowniczek, Artur <[email protected]>

AdamGlustein requested changes Jul 23, 2024

View reviewed changes

cpp/csp/python/PyEngine.h Outdated Show resolved Hide resolved

cpp/csp/python/PyEngine.h Outdated Show resolved Hide resolved

cpp/csp/python/PyEngine.h Outdated Show resolved Hide resolved

cpp/csp/python/PyEngine.h Outdated Show resolved Hide resolved

argaj added 2 commits July 24, 2024 09:01

use PyObjectPtr, add space to error msg

9c89a39

Signed-off-by: Gajowniczek, Artur <[email protected]>

Merge branch 'main' of https://github.com/Point72/csp into ag/expose-…

7388bff

…engine-shutdown Signed-off-by: Gajowniczek, Artur <[email protected]>

robambalu requested changes Jul 24, 2024

View reviewed changes

cpp/csp/python/PyAdapterManager.cpp Outdated Show resolved Hide resolved

cpp/csp/python/PyEngine.h Outdated Show resolved Hide resolved

AdamGlustein requested review from robambalu and AdamGlustein July 24, 2024 13:17

AdamGlustein previously approved these changes Jul 24, 2024

View reviewed changes

argaj dismissed AdamGlustein’s stale review via 9de217f July 25, 2024 12:42

use METH_O in shutdown_engine

52ee0e1

Signed-off-by: Gajowniczek, Artur <[email protected]>

argaj force-pushed the ag/expose-engine-shutdown branch from 9de217f to 52ee0e1 Compare July 25, 2024 12:44

robambalu approved these changes Jul 25, 2024

View reviewed changes

argaj merged commit dce7312 into main Jul 25, 2024
30 checks passed

argaj deleted the ag/expose-engine-shutdown branch July 25, 2024 15:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

expose engine shutdown to adapter manager and push/pushpull adapters #312

expose engine shutdown to adapter manager and push/pushpull adapters #312

argaj commented Jul 3, 2024

robambalu left a comment

AdamGlustein commented Jul 11, 2024

AdamGlustein commented Jul 24, 2024 •

edited

Loading

expose engine shutdown to adapter manager and push/pushpull adapters #312

expose engine shutdown to adapter manager and push/pushpull adapters #312

Conversation

argaj commented Jul 3, 2024

robambalu left a comment

Choose a reason for hiding this comment

AdamGlustein commented Jul 11, 2024

AdamGlustein commented Jul 24, 2024 • edited Loading

AdamGlustein commented Jul 24, 2024 •

edited

Loading