Run websocket tests (#411)

Add python-rapidjson Add build related package constraints Narrow down macos conda build failures Clang17 option to not assume unique vtables Signed-off-by: Nijat Khanbabayev <[email protected]>
Point72 · Dec 4, 2024 · eaed668 · eaed668
1 parent ac07bd9
commit eaed668
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 15 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -204,6 +204,11 @@ else()
             -Wno-maybe-uninitialized \
             ")
         endif()
+        if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+            if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 17)
+                set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-assume-unique-vtables")
+            endif()
+        endif()
     endif()
 endif()
 

diff --git a/csp/tests/adapters/test_websocket.py b/csp/tests/adapters/test_websocket.py
@@ -1,31 +1,32 @@
 import os
 import pytz
 import threading
+import tornado.ioloop
+import tornado.web
+import tornado.websocket
 import unittest
 from datetime import datetime, timedelta
+from tornado.testing import bind_unused_port
 from typing import List
 
 import csp
 from csp import ts
+from csp.adapters.websocket import JSONTextMessageMapper, RawTextMessageMapper, Status, WebsocketAdapterManager
 
-if os.environ.get("CSP_TEST_WEBSOCKET"):
-    import tornado.ioloop
-    import tornado.web
-    import tornado.websocket
 
-    from csp.adapters.websocket import JSONTextMessageMapper, RawTextMessageMapper, Status, WebsocketAdapterManager
+class EchoWebsocketHandler(tornado.websocket.WebSocketHandler):
+    def on_message(self, msg):
+        return self.write_message(msg)
 
-    class EchoWebsocketHandler(tornado.websocket.WebSocketHandler):
-        def on_message(self, msg):
-            return self.write_message(msg)
 
-
-@unittest.skipIf(not os.environ.get("CSP_TEST_WEBSOCKET"), "Skipping websocket adapter tests")
 class TestWebsocket(unittest.TestCase):
     @classmethod
     def setUpClass(cls):
         cls.app = tornado.web.Application([(r"/", EchoWebsocketHandler)])
-        cls.app.listen(8000)
+        sock, port = bind_unused_port()
+        sock.close()
+        cls.port = port
+        cls.app.listen(port)
         cls.io_loop = tornado.ioloop.IOLoop.current()
         cls.io_thread = threading.Thread(target=cls.io_loop.start)
         cls.io_thread.start()
@@ -44,7 +45,7 @@ def send_msg_on_open(status: ts[Status]) -> ts[str]:
 
         @csp.graph
         def g():
-            ws = WebsocketAdapterManager("ws://localhost:8000/")
+            ws = WebsocketAdapterManager(f"ws://localhost:{self.port}/")
             status = ws.status()
             ws.send(send_msg_on_open(status))
             recv = ws.subscribe(str, RawTextMessageMapper())
@@ -67,7 +68,7 @@ def send_msg_on_open(status: ts[Status]) -> ts[str]:
 
         @csp.graph
         def g():
-            ws = WebsocketAdapterManager("ws://localhost:8000/")
+            ws = WebsocketAdapterManager(f"ws://localhost:{self.port}/")
             status = ws.status()
             ws.send(send_msg_on_open(status))
             recv = ws.subscribe(MsgStruct, JSONTextMessageMapper())
@@ -106,7 +107,7 @@ def stop_on_all_or_timeout(msgs: ts[str], l: int = 50) -> ts[bool]:
 
         @csp.graph
         def g(n: int):
-            ws = WebsocketAdapterManager("ws://localhost:8000/")
+            ws = WebsocketAdapterManager(f"ws://localhost:{self.port}/")
             status = ws.status()
             ws.send(csp.flatten([send_msg_on_open(status, i) for i in range(n)]))
             recv = ws.subscribe(str, RawTextMessageMapper())
@@ -145,7 +146,7 @@ def my_edge_that_handles_burst(objs: ts[List[MsgStruct]]) -> ts[bool]:
 
         @csp.graph
         def g():
-            ws = WebsocketAdapterManager("ws://localhost:8000/")
+            ws = WebsocketAdapterManager(f"ws://localhost:{self.port}/")
             status = ws.status()
             ws.send(send_msg_on_open(status))
             recv = ws.subscribe(MsgStruct, JSONTextMessageMapper(), push_mode=csp.PushMode.BURST)

diff --git a/pyproject.toml b/pyproject.toml
@@ -86,6 +86,7 @@ develop = [
     "sqlalchemy",  # db
     "threadpoolctl",  # test_random
     "tornado",  # profiler, perspective, websocket
+    "python-rapidjson", # websocket
     # type checking
     "pydantic>=2",
 ]