Address code review comments

Signed-off-by: Petr Ogarok <[email protected]>
Point72 · Jun 18, 2024 · cf02f94 · cf02f94
1 parent 3143fb0
commit cf02f94
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 18 deletions.
diff --git a/cpp/csp/python/PyStructFastList_impl.h b/cpp/csp/python/PyStructFastList_impl.h
@@ -517,16 +517,8 @@ static PyObject * PyStructFastList_reduce( PyStructFastList<StorageT> * self, Py
     CSP_BEGIN_METHOD;
 
     typename VectorWrapper<StorageT>::IndexType sz = self -> vector.size();
-    PyObject * args = PyTuple_New( sz );
     PyObjectPtr list = PyObjectPtr::own( toPython( self -> vector.getVector(), self -> arrayType ) );
-    for( typename VectorWrapper<StorageT>::IndexType index = 0; index < sz; ++index )
-    {
-        PyObject * value = PyList_GET_ITEM( list.ptr(), index );
-        Py_INCREF( value );
-        PyTuple_SET_ITEM( args, index, value );
-    }
-    PyObject * result = Py_BuildValue( "O(O)", &PyList_Type, args );
-    Py_INCREF( result );
+    PyObject * result = Py_BuildValue( "O(O)", &PyList_Type, list.ptr() );
     return result;
 
     CSP_RETURN_NULL;

diff --git a/cpp/csp/python/PyStructList_impl.h b/cpp/csp/python/PyStructList_impl.h
@@ -303,15 +303,8 @@ static PyObject * PyStructList_reduce( PyStructList<StorageT> * self, PyObject *
     CSP_BEGIN_METHOD;
 
     typename VectorWrapper<StorageT>::IndexType sz = self -> vector.size();
-    PyObject * args = PyTuple_New( sz );
-    for( typename VectorWrapper<StorageT>::IndexType index = 0; index < sz; ++index )
-    {
-        PyObject * value = PyList_GET_ITEM( ( PyObject * ) self, index );
-        Py_INCREF( value );
-        PyTuple_SET_ITEM( args, index, value );
-    }
-    PyObject * result = Py_BuildValue( "O(O)", &PyList_Type, args );
-    Py_INCREF( result );
+    PyObjectPtr list = PyObjectPtr::own( toPython( self -> vector.getVector(), self -> arrayType ) );
+    PyObject * result = Py_BuildValue( "O(O)", &PyList_Type, list.ptr() );
     return result;
 
     CSP_RETURN_NULL;