594 Fix formChild is null

[leonstr]

When a student completed a questionnaire then shown the "Thank you for completing this Questionnaire" page there was a JavaScript error:

Uncaught TypeError: formChild is null

This was because the JavaScript for the questions form was being inadvertently loaded for the Thank you page where this form is not present.

[mchurchward]

This will need to rebased with the latest MOODLE_401_STABLE so that only this PR's commit is present.

[leonstr]

Apologies, rebased, hopefully this is correct now.

Edit: No it isn't. More apologies. I'll see if I can sort this out.

[leonstr]

Maybe it is correct after all, please let me know if there are still issues with this.

[mchurchward]

There was a fix added to the javascript here. This may already fix the problem you describe?

[leonstr]

There was a fix added to the javascript here. This may already fix the problem you describe?

No, in fact this issue only occurs once that fix has been applied. Fix 852486f allows the form checker to be run with Moodle 4.4 (instead of getting a console error), but this means a long-time bug re-emerges due to the form checker being incorrectly loaded for the "Thank you" page. If in doubt, install the latest MOODLE_401_STABLE of mod_questoinnaire and follow the steps in #594.

[mchurchward]

I don't get that error using the latest MOODLE_401_STABLE.

[leonstr]

I don't get that error using the latest MOODLE_401_STABLE.

On the Thank You page? That's a mystery since there's no DOM element with the ID specified by the form checker code.

I've just retested, on Moodle 4.4.2+ (Build: 20240823) with mod_questionnaire 5c0dbe8 and still see the error if I follow the steps from #594 (slightly different error because it's a different browser):

[mchurchward]

Ah. Okay. I didn't realize you meant in the console. Yes, I do see that.

[mchurchward]

Thanks for the clarification.