restore_radar_charttype rebased to MOODLE_401_STABLE

[rezeau]

This PR replaces obsolete PR #490

[mchurchward]

Can Behat tests be updated/added to verify these?

[rezeau]

@mchurchward wrote "Can Behat tests be updated/added to verify these?"
I've checked that the existing Behat test add_multi_feedback_with_sections.feature works OK with this PR.
Do you prefer me to update that Behat test with my PR new features OR create a new test?

[mchurchward]

Hi Joseph. Sorry it has taken so long to get back to this.
I'm having trouble testing it. I have existing questionnaires with feedback options already in the database.
The questionnaire has a normal rate question.
But when I try to access the feedback for editing, I get the message:
"Feedback options are available if your questionnaire contains the following question types and question settings: Radio buttons; Dropdown box; Yes/No; or Rate (normal or Osgood scale). Those questions must be set as Required, their Question Name field must NOT be empty and the Possible answers choices must contain a value. "
This error happens on the current MOODLE_401_STABLE branch as well as the one you have provided here.

What am I doing wrong?

[rezeau]

@mchurchward I've just tested my PR #510 on my local moodle test site running Moodle 4.3.3+ (Build: 20240215). It works as expected.
You write:: "The questionnaire has a normal rate question.
But when I try to access the feedback for editing, I get the message:
"Feedback options are available if your questionnaire contains the following question types and question settings: Radio buttons; Dropdown box; Yes/No; or Rate (normal or Osgood scale). Those questions must be set as Required, their Question Name field must NOT be empty and the Possible answers choices must contain a value. ""
1.- Are you positive that your questionnaire obeys all the conditions mentioned in the Feedback options warning message?
2.- If you try your to add Feedback to your questionnaire without using my PR, are you getting the same message? My PR has nothing to do with those Feedback requirements, i.e. it does not add any extra requirement to the list.

[rezeau]

@mchurchward Should I wait for #542 and @lucaboesch 's suggestion :: "A branch MOODLE_403_STABLE in your repository would be highly appreciated" before continuing testing this #510 ?

[joostelshoff]

@mchurchward What is the current status of this fix?