-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open and close date in course overview #441
base: MOODLE_400_STABLE
Are you sure you want to change the base?
Conversation
a976175
to
14e0e5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the CI issues.
Also, I'm unclear on what the new "dates" class does. You have added it, but I do not see it being used anywhere?
fixed the errors. The dates class is used by the moodle core. It preps the dates to be displayed in the course view. In this case it is used to determine the label for the dates. You could use it to display all kind of dates. A very similar usage is in the quiz module and a different implementation is in the forum module. Although the difference isn't to big. |
Thanks for your responses... |
Sorry for the delay and the mess with the worflow runs. I rebased the code, changed some lines to work with the new base and added the behat test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as expected
Hi,
we've added the feature to display the open and close date for the activity in the course overview. If you need any changes to the code please let me know.
best wishes,
adrian