Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open and close date in course overview #441

Open
wants to merge 4 commits into
base: MOODLE_400_STABLE
Choose a base branch
from

Conversation

aczerzuh
Copy link

Hi,
we've added the feature to display the open and close date for the activity in the course overview. If you need any changes to the code please let me know.
best wishes,
adrian

Copy link
Contributor

@mchurchward mchurchward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI issues.

Also, I'm unclear on what the new "dates" class does. You have added it, but I do not see it being used anywhere?

@aczerzuh
Copy link
Author

fixed the errors.

The dates class is used by the moodle core. It preps the dates to be displayed in the course view. In this case it is used to determine the label for the dates.

You could use it to display all kind of dates. A very similar usage is in the quiz module and a different implementation is in the forum module. Although the difference isn't to big.

@mchurchward
Copy link
Contributor

Thanks for your responses...
Are you able to add a Behat test for this? It would be good to have that to avoid future regressions.
Also, is this something that would apply to 3.11 as well?

@aczerzuh aczerzuh reopened this Mar 3, 2023
@aczerzuh
Copy link
Author

aczerzuh commented Mar 3, 2023

Sorry for the delay and the mess with the worflow runs. I rebased the code, changed some lines to work with the new base and added the behat test.
The activity dates can also be displayed in Moodle 3.11, but the support for this version ends pretty soon.
best wishes

Copy link
Contributor

@rezeau rezeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants