feat(preview): adding standardized preview data cards #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassrock
changed the title
bassrock
requested review from
cjkim1995 and
collectedmind
and removed request for
a team and
cjkim1995
bassrock
commented
Aug 27, 2024
| @@ -0,0 +1,556 @@ | |||
| extend schema | |||
There was a problem hiding this comment.
I had to add a seperate schema for admin because federation gets mad since our admin api does not implement some of the shared objects
bassrock
force-pushed
the
feat/displayData
branch
from
3ee6ed3 to
9b6a97f
Compare
kschelonka
reviewed
Aug 28, 2024
| schema: | ||
| subgraph_url: https://list-api.readitlater.com | ||
| parser: | ||
| #routing_url: https://parser-graphql-wrapper.readitlater.com |
There was a problem hiding this comment.
reason this one is commented out?
There was a problem hiding this comment.
Was running it locally against my local parser
kschelonka
reviewed
Aug 28, 2024
| collection: | ||
| routing_url: https://collection-api.readitlater.com | ||
| # schema: | ||
| # subgraph_url: https://collection-api.readitlater.com |
There was a problem hiding this comment.
are these below commented out due to no introspection?
collectedmind
approved these changes
Aug 28, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Standardize all display logic across Pocket using the Preview Entity.
Requires: Pocket/content-monorepo#210
Implementation Details
I chose to specifically use GraphQL to do our intersystem communication so that we could focus on merging logic. For now this works pretty well and the router handles all flattening in our resolvers
https://mozilla-hub.atlassian.net/browse/POCKET-10474