Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): tag docker image with 'latest' #1027

Merged
merged 1 commit into from
Jan 14, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/actions/containerize/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ inputs:
required: true

outputs:
docker-image-name:
docker-image-name:
description: The full name with registry of the built docker image
value: ${{ steps.get-build-name.outputs.docker-image-name }}

Expand All @@ -49,8 +49,8 @@ runs:
# can be useful if you want to add emulation support with QEMU to be able to build against more platforms.
- name: Set up QEMU
uses: docker/setup-qemu-action@v3
# action will create and boot a builder using by default the docker-container driver.

# action will create and boot a builder using by default the docker-container driver.
# This is not required but recommended using it to be able to build multi-platform images, export cache, etc.
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
Expand All @@ -64,13 +64,13 @@ runs:
- name: Login to Amazon ECR
if: inputs.push == 'true'
uses: aws-actions/amazon-ecr-login@v2

- name: Build docker image
id: docker-build-push
uses: docker/build-push-action@v6
with:
push: ${{inputs.push}}
tags: ${{inputs.docker-repo-name}}:${{ github.sha }}
tags: ${{inputs.docker-repo-name}}:${{ github.sha }},latest
context: ${{ inputs.context }}
build-args: |
GIT_SHA=${{ github.sha }}
Expand All @@ -81,8 +81,8 @@ runs:
PORT=${{inputs.app-port}}
secrets: |
sentry_token=${{ inputs.sentry-token }}
- name: Output Build Name
- name: Output Build Name
id: get-build-name
shell: bash
run: |
echo "docker-image-name=${{inputs.docker-repo-name}}:${{ github.sha }}" >> $GITHUB_OUTPUT
echo "docker-image-name=${{inputs.docker-repo-name}}:${{ github.sha }}" >> $GITHUB_OUTPUT
Loading