Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): bump parser request timeout #1017

Merged
merged 3 commits into from
Jan 8, 2025
Merged

fix(parser): bump parser request timeout #1017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb5c5dd
fix(parser): bump parser request timeout
kschelonka Jan 8, 2025
ad4d225
fix(router): add client info to metrics and spans
kschelonka Jan 8, 2025
512bb69
fix(router): add client info to metrics and spans
kschelonka Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions servers/client-api/config/router.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,24 @@ telemetry:
# https://www.apollographql.com/docs/graphos/reference/router/telemetry/instrumentation/instruments#default_requirement_level
default_requirement_level: recommended
router:
http.server.active_requests: true # (default false)
http.server.request.body.size: true # (default false)
http.server.request.duration: true # (default false)
http.server.active_requests:
attributes:
'http.request.header.apollographql-client-name':
request_header: 'apollographql-client-name'
'http.request.header.apollographql-client-version':
request_header: 'apollographql-client-version'
http.server.request.body.size:
attributes:
'http.request.header.apollographql-client-name':
request_header: 'apollographql-client-name'
'http.request.header.apollographql-client-version':
request_header: 'apollographql-client-version'
http.server.request.duration:
attributes:
'http.request.header.apollographql-client-name':
request_header: 'apollographql-client-name'
'http.request.header.apollographql-client-version':
request_header: 'apollographql-client-version'
subgraph:
http.client.request.body.size: true # (default false)
http.client.request.duration: true # (default false)
Expand Down Expand Up @@ -126,9 +141,16 @@ telemetry:
graphql.operation.name: true
cost.delta: true
spans:
mode: spec_compliant
supergraph:
attributes:
cost.estimated: true
router:
attributes:
'http.request.header.apollographql-client-name':
request_header: 'apollographql-client-name'
'http.request.header.apollographql-client-version':
request_header: 'apollographql-client-version'

apollo:
send_variable_values:
Expand Down
2 changes: 1 addition & 1 deletion servers/parser-graphql-wrapper/src/config/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export default {
process.env.PARSER_BASE_ENDPOINT || 'http://example-parser.com',
dataPath: process.env.PARSER_DATA_PATH || '/wrapper',
retries: 3,
timeout: 5,
timeout: 25,
},
dynamoDb: {
itemSummaryTable: {
Expand Down
Loading