Skip to content

Commit

Permalink
chore(ci): adding in dockerhub login
Browse files Browse the repository at this point in the history
  • Loading branch information
bassrock committed Aug 14, 2024
1 parent 11e6f98 commit cbf54ec
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 19 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/user_api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,16 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Set up Docker Compose
run: |
sudo apt-get update
sudo apt-get install -y docker-compose

- name: Login to Docker Hub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}

# Kick off starting docker compose first, since it can take a bit
- name: Start Docker Compose services
run: docker-compose up -d
run: docker compose up -d

# While we wait for docker compose to be healthy we install node and needed packages.
- name: Install pnpm & node
Expand All @@ -33,7 +34,6 @@ jobs:

# Step 4: Wait for the services to be healthy
- name: Wait for services to be healthy
run: |
docker-compose wait
run: docker compose up --wait
- name: Run service integration tests
run: pnpm run test-integrations --filter=user-api...
12 changes: 1 addition & 11 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,7 @@
version: '3'
services:
## Start Common Processes Config
# Note this is not the collector we use in Prod, but works for local testing
otlpcollector:
image: grafana/otel-lgtm
platform: linux/amd64
environment:
OTEL_METRIC_EXPORT_INTERVAL: 1
ports:
- 4317:4317 # OTLP gRPC receiver
- 4318:4318 # OTLP http receiver
- 3000:3000 # Grafana UI admin:admin, use localhost:3000 to view traces

# Note this is not the collector we use in Prod, but works for local testing & github actions
memcached:
image: memcached:latest
ports:
Expand Down

0 comments on commit cbf54ec

Please sign in to comment.