fix(PDF_CA): modifications pour PDF d'un cadre d'acquisition #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix-2-15-1 #3252 +/- ##
==============================================
+ Coverage 83.91% 83.94% +0.03%
==============================================
Files 122 122
Lines 9698 9707 +9
==============================================
+ Hits 8138 8149 +11
+ Misses 1560 1558 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
VincentCauchois
changed the title
VincentCauchois
changed the title
VincentCauchois
force-pushed
the
feat/adjust-depobio-pdf
branch
3 times, most recently
from
4ccdd53 to
21e24d3
Compare
List of modifications: - Display label rather than ID for nomenclature_territorial_level associated to "Etendue territoriale" - Do not display "Cible taxonomique" section if `data['target_description']` is empty i.e. if there is no information to display - Change "Liste des jeux de données associés au cadre" to "Liste des jeux de données associés" - Add count of Synthese observations for each dataset listed, associated to "Nombre d'observations" // change `get_export_pdf_acquisition_frameworks` endpoint to add these counts - Use `data.datasets` rather than `data.t_datasets`
Pierre-Narcisi
force-pushed
the
feat/adjust-depobio-pdf
branch
from
21e24d3 to
cc91c6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.