feat: add Event DRAWSTOP (improve ux) #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2779 +/- ##
========================================
Coverage 68.56% 68.56%
========================================
Files 86 86
Lines 7435 7435
========================================
Hits 5098 5098
Misses 2337 2337
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andriacap
force-pushed
the
ux/improve-map-component-keep-geom
branch
4 times, most recently
from
6b50c71 to
6fb173b
Compare
Avant à l'ajout d'une géométrie si on annulait ("cancel") l'ajout de la
géométrie alors on revenait sur une map sans aucune layer (la layer
d'origine n'était plus présente)
L'ajout de l'event DRAWSTOP permet de gérer ce cas de figure et
améliorer l'UX
Reviewed-by: andriacap
Remove useless code Reviewed-by: andriacap and theo
andriacap
force-pushed
the
ux/improve-map-component-keep-geom
branch
from
6fb173b to
1653cb1
Compare
camillemonchicourt
requested review from
TheoLechemia
and removed request for
TheoLechemia
TheoLechemia
approved these changes
Dec 11, 2023
jacquesfize
added
available-in-next-release
and removed
solved in next release
available-in-next-release
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avant à l'ajout d'une géométrie si on annulait ("cancel") l'ajout de la géométrie alors on revenait sur une map sans aucune layer (la layer d'origine n'était plus présente)
L'ajout de l'event DRAWSTOP permet de gérer ce cas de figure et améliorer l'UX
[Refs_ticket] : #2778
Reviewed-by: andriacap