forked from thomas-bouvier/persistent-cookie-jar-okhttp
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datastore kotlin impl #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlospontual
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I just had one suggestion
secure nexus repository usage
secure nexus repository usage
AndreuZaitsev
force-pushed
the
datastore-kotlin-impl
branch
from
March 18, 2024 17:18
4390f28
to
f5b8f23
Compare
carlospontual
force-pushed
the
datastore-kotlin-impl
branch
from
March 18, 2024 19:46
5327428
to
a10e5fa
Compare
carlospontual
force-pushed
the
datastore-kotlin-impl
branch
from
March 18, 2024 19:49
a10e5fa
to
08be279
Compare
carlospontual
force-pushed
the
datastore-kotlin-impl
branch
2 times, most recently
from
March 18, 2024 20:58
811fb59
to
afa15e0
Compare
carlospontual
force-pushed
the
datastore-kotlin-impl
branch
2 times, most recently
from
March 18, 2024 21:45
9aa5fbc
to
b7006cb
Compare
carlospontual
force-pushed
the
datastore-kotlin-impl
branch
from
March 18, 2024 21:50
b7006cb
to
486c11e
Compare
carlospontual
force-pushed
the
datastore-kotlin-impl
branch
3 times, most recently
from
March 19, 2024 00:15
f2ffbb4
to
bb87ddc
Compare
carlospontual
force-pushed
the
datastore-kotlin-impl
branch
from
March 19, 2024 00:20
bb87ddc
to
f294e39
Compare
...p/src/test/java/com/andreuzaitsev/persistentcookiejar/robolectric/PersistentCookieJarTest.kt
Outdated
Show resolved
Hide resolved
...t/java/com/andreuzaitsev/datastorepersistentcookiejar/robolectric/PersistentCookieJarTest.kt
Outdated
Show resolved
Hide resolved
persistent-cookie-jar-okhttp/src/test/java/com/andreuzaitsev/common/SerializableCookieTest.kt
Outdated
Show resolved
Hide resolved
carlospontual
force-pushed
the
datastore-kotlin-impl
branch
from
March 19, 2024 16:08
c8f286b
to
31fbeaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjustments to make the Library non-blocking