New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update webvtt parse to v1.0.x #18

Open

juani-binagora wants to merge 4 commits into master from bugfix/WEBTECH-15643

juani-binagora commented Aug 2, 2021 •

edited

Loading

This PR will...

Update the parse used for webvtt files.

Why is this Pull Request needed?

Currently the offset for the webvtt CCs is off, causing them to not show in some channels

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

changes have been done against master branch, and PR does not conflict
new unit / functional tests have been added (whenever applicable)
API or design changes are documented in API.md

juani-binagora added 4 commits

July 29, 2021 16:21


          chore: convert webvtt-parser into typescript file

9105b11


          update webvtt-parser to v1.0.x

a296378


          use timescale to sync CC correctly

71dd111


          update build files

314d19f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet