Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(external_messaging_name): Fix untrusted external messaging name check #963

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

sleekslush
Copy link
Contributor

Details

Data is untrusted, so this fixes the case statement to handle a potentially non-existent name field (or undefined/null request data).

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I agree to license this contribution under the MIT LICENSE
  • I checked the current PR for duplication.

Contacts

  • (OPTIONAL) Discord ID: filthytone

If your PR is accepted, we will award you with the Contributor role on Discord server.

To join the server, visit: https://www.plasmo.com/s/d

@sleekslush sleekslush changed the title Fix external messaging name fix(external_messaging_name): Fix untrusted external messaging name check Apr 25, 2024
Copy link
Contributor

@louisgv louisgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@louisgv louisgv merged commit 9f8359c into PlasmoHQ:main Apr 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants