Fix deletion of output.overrides (#1064)

* Fix overrides removal. * Add test run after examples build. * Up examples ref. --------- Co-authored-by: L <[email protected]>
PlasmoHQ · Sep 13, 2024 · 265c66f · 265c66f
1 parent 6c30aaa
commit 265c66f
Show file tree

Hide file tree

Showing 5 changed files with 705 additions and 91 deletions.
diff --git a/.github/workflows/test-examples.yml b/.github/workflows/test-examples.yml
@@ -63,3 +63,4 @@ jobs:
           #   popd
           # done
           # popd
+          pnpm run test:examples
diff --git a/cli/plasmo/src/features/manifest-factory/base.ts b/cli/plasmo/src/features/manifest-factory/base.ts
@@ -626,8 +626,8 @@ export abstract class PlasmoManifest<T extends ExtensionManifest = any> {
 
     if (output.overrides && output.overrides[this.browser]) {
       output = { ...output, ...output.overrides[this.browser] }
-      delete output.overrides
     }
+    delete output.overrides
     return this.injectEnvToObj(output)
   }
 

diff --git a/examples b/examples
diff --git a/package.json b/package.json
@@ -16,6 +16,7 @@
     "build:api": "turbo run build --filter \"./api/**\"",
     "build:core": "turbo run build --filter \"./core/**\"",
     "build:examples": "pnpm --filter \"./examples/**\" -r build",
+    "test:examples": "pnpm --filter \"./examples/**\" -r test",
     "publish:packages": "pnpm --filter \"./packages/**\" publish",
     "publish:api": "pnpm --filter \"./api/**\" publish",
     "publish:core": "pnpm --filter \"./core/**\" publish",
@@ -62,4 +63,4 @@
     "node": ">=18.0.0"
   },
   "packageManager": "[email protected]"
-}
+}