Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: firefox source code submission #94

Merged
merged 1 commit into from
Nov 13, 2024
Merged

feat: firefox source code submission #94

merged 1 commit into from
Nov 13, 2024

Conversation

DanielSinclair
Copy link
Contributor

Changes

  • expose source, source-zip and source-file parameters in bpp to allow submission of source code which is required by firefox for bundled extensions
  • amended bms package to expose the underlying submission keys

@DanielSinclair
firefox source upload
ca76cbf 
fix: expose source in action.yml
@DanielSinclair DanielSinclair marked this pull request as ready for review November 13, 2024 08:34
louisgv
louisgv approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@louisgv louisgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@louisgv louisgv changed the title firefox source code submission feat: firefox source code submission Nov 13, 2024
@louisgv louisgv merged commit 1e53135 into PlasmoHQ:main Nov 13, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisgv louisgv louisgv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielSinclair @louisgv