Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

[WIP] Electron config class #23

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

lemmatum
Copy link
Collaborator

@lemmatum lemmatum commented Dec 16, 2017

Beginnings of classes for subshells, electron configurations, term symbols, energy levels, and transitions (each one building off of the former).

PR is not ready yet, just doing this for easier tracking/discussing.

Addresses #4

@pep8speaks
Copy link

pep8speaks commented Dec 16, 2017

Hello @lemmatum! Thanks for updating your pull request.

Line 80:54: W291 trailing whitespace
Line 89:1: W293 blank line contains whitespace
Line 94:72: W291 trailing whitespace
Line 119:1: E265 block comment should start with '# '
Line 149:16: E261 at least two spaces before inline comment
Line 150:16: E261 at least two spaces before inline comment
Line 151:16: E261 at least two spaces before inline comment
Line 152:16: E261 at least two spaces before inline comment
Line 185:1: E265 block comment should start with '# '
Line 186:1: E302 expected 2 blank lines, found 1
Line 215:5: E301 expected 1 blank line, found 0
Line 221:9: E743 ambiguous function definition 'l'
Line 232:5: E301 expected 1 blank line, found 0
Line 244:5: E301 expected 1 blank line, found 0
Line 256:5: E301 expected 1 blank line, found 0
Line 279:19: E711 comparison to None should be 'if cond is None:'
Line 282:5: E301 expected 1 blank line, found 0
Line 288:1: W293 blank line contains whitespace
Line 290:1: W293 blank line contains whitespace
Line 292:25: W291 trailing whitespace
Line 303:1: E265 block comment should start with '# '
Line 317:59: W291 trailing whitespace
Line 322:1: W293 blank line contains whitespace
Line 324:1: W293 blank line contains whitespace
Line 325:1: W293 blank line contains whitespace
Line 326:9: E303 too many blank lines (2)
Line 328:1: W293 blank line contains whitespace
Line 331:1: W293 blank line contains whitespace
Line 333:1: W293 blank line contains whitespace
Line 336:27: W291 trailing whitespace
Line 337:1: W293 blank line contains whitespace
Line 338:72: W291 trailing whitespace
Line 341:5: E301 expected 1 blank line, found 0
Line 352:5: E301 expected 1 blank line, found 0
Line 361:5: E301 expected 1 blank line, found 0
Line 375:1: W293 blank line contains whitespace
Line 377:1: W293 blank line contains whitespace
Line 379:1: W293 blank line contains whitespace
Line 381:5: E301 expected 1 blank line, found 0
Line 387:5: E301 expected 1 blank line, found 0
Line 393:5: E301 expected 1 blank line, found 0
Line 400:19: W291 trailing whitespace
Line 408:1: W293 blank line contains whitespace
Line 411:1: E265 block comment should start with '# '
Line 411:1: E303 too many blank lines (3)
Line 413:1: E302 expected 2 blank lines, found 3
Line 432:1: E265 block comment should start with '# '
Line 457:5: E301 expected 1 blank line, found 0
Line 462:5: E301 expected 1 blank line, found 0

Line 10:19: W292 no newline at end of file

Comment last updated on July 04, 2018 at 05:30 Hours UTC

@lemmatum lemmatum added this to the v0.1 milestone Dec 16, 2017
@lemmatum lemmatum changed the title Electron config class [WIP] Electron config class Apr 20, 2018
lemmatum added 11 commits May 10, 2018 22:11
…ubshells will then be built into full electron configurations. Full electron configurations will then be joined with term symbol to describe energy level. Two energy levels will then describe a transition. Should then generate a way of handling sets of these transition objects for the purposes of simulations.
…from SpectroscoPy due to package name change.
@lemmatum lemmatum force-pushed the electronConfigClass branch from a99d7c1 to 55a3ff1 Compare May 11, 2018 04:19
@StanczakDominik StanczakDominik self-requested a review July 13, 2018 05:06
@StanczakDominik StanczakDominik removed their request for review February 8, 2020 13:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants